Sequence not String #1574
Merged
Sequence not String #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 91.56% 91.58% +0.01%
==========================================
Files 120 120
Lines 16797 16830 +33
==========================================
+ Hits 15381 15414 +33
Misses 1416 1416
|
haakonvt
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Awesome! Found a few more:
expressionsinSyntheticDatapointsAPI.querypropertiesinThreeDRevisionsAPI.filter_nodeslabelsinLabel._load_list
Could you also fix this docstring:
template_names (SequenceNotStr[str] | None): (Optional[Sequence[str]]): Only include instances which has one of these values in their `template_name` field.
->
template_names (SequenceNotStr[str] | None): Only include instances which has one of these values in their `template_name` field.
# Conflicts: # cognite/client/data_classes/extractionpipelines.py
haakonvt
reviewed
Jan 17, 2024
CHANGELOG.md
Outdated
Comment on lines
20
to
23
| ## [7.13.3] - 2024-01-11 | ||
| ### Changed | ||
| - Type hints `Sequence[str]` are now replaced with `SequenceNotStr[str]`. | ||
|
|
There was a problem hiding this comment.
Thinking is to have released version consistent with the docs. However, you are right we do not do this, (and we release so often that it will not be outdated for long anyways). Removing as it is no change to functionality.
| asset_subtree_ids: int | Sequence[int] | None = None, | ||
| asset_subtree_external_ids: str | Sequence[str] | None = None, | ||
| asset_subtree_external_ids: str | SequenceNotStr[str] | None = None, |
There was a problem hiding this comment.
Not that relevant when we also accept str, but won't hurt.
cognite/client/_api/three_d.py
Outdated
There was a problem hiding this comment.
Check line endings on this file, looks suspicious
There was a problem hiding this comment.
Another file for line ending check
# Conflicts: # CHANGELOG.md # cognite/client/_version.py # pyproject.toml
doctrino
commented
Jan 19, 2024
haakonvt
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Lgtm, does @erlendvollset want to have a look before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.