fix files/upload for files using geo_location #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
- Coverage 91.58% 91.52% -0.06%
==========================================
Files 120 120
Lines 16830 16833 +3
==========================================
- Hits 15413 15407 -6
- Misses 1417 1426 +9
|
doctrino
reviewed
Jan 19, 2024
| if geo_location is not None and not isinstance(geo_location, GeoLocation): | ||
| raise TypeError("FileMetadata.geo_location should be of type GeoLocation") | ||
| if geo_location is not None: | ||
| if isinstance(geo_location, dict): |
There was a problem hiding this comment.
How is a dict passed in here? That should not happen
doctrino
approved these changes
Jan 19, 2024
haakonvt
force-pushed
the
fix-files-upload-geo-loc
branch
from
c522c64 to
3279497
Compare
johanlrdahl
pushed a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[7.13.8] - 2024-01-19
Fixed
FilesAPI.uploadwhen usinggeo_location(serialize error).Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.