Skip to content

fix response assertion in data modeling tests #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

lpereiracgn
Copy link
Contributor

@lpereiracgn lpereiracgn commented Apr 24, 2025

Description

Update in the API response for errors is making the tests fail.

Screenshot 2025-04-24 at 23 33 40

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@lpereiracgn lpereiracgn requested review from a team as code owners April 24, 2025 21:34
@lpereiracgn lpereiracgn mentioned this pull request Apr 24, 2025
4 tasks
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (13598ad) to head (f6feb8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
- Coverage   90.53%   90.52%   -0.01%     
==========================================
  Files         158      158              
  Lines       23753    23753              
==========================================
- Hits        21504    21502       -2     
- Misses       2249     2251       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doctrino doctrino requested a review from a team April 25, 2025 07:14
@doctrino doctrino added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Apr 25, 2025
@thorkildcognite
Copy link
Contributor

risk review ok

@thorkildcognite thorkildcognite self-assigned this Apr 28, 2025
@thorkildcognite thorkildcognite added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Apr 28, 2025
@lpereiracgn lpereiracgn added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit 56d96c7 Apr 28, 2025
17 checks passed
@lpereiracgn lpereiracgn deleted the fix-data-modeling-error-resp branch April 28, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants