[Cm-1631]: Implement Artifact Uploading #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-like data. Updated all related usage places. Implemented test cases.
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
============================================
- Coverage 53.62% 52.46% -1.17%
- Complexity 429 489 +60
============================================
Files 65 87 +22
Lines 1848 2272 +424
Branches 155 174 +19
============================================
+ Hits 991 1192 +201
- Misses 644 836 +192
- Partials 213 244 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Outdated
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Outdated
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Outdated
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Outdated
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Outdated
Show resolved
Hide resolved
…. Implemented corresponding test cases. Refactored test cases to extract asset folder related functionality to be used from different test suites.
…dardCharsets.UTF_8 charset.
…h printStackTrace.
…s. Exposed ExperimentMetadata public DTO object.
…lated methods and test cases.
…d related methods and test cases.
…fields to be extended by REST API model classes for inheritance.
…describing particular asset. Fixed related methods and test cases.
… public API. Fixed related test cases. Fixed CometApi to return ExperimentMetadata from public API. Fixed related test cases. Renamed internal model package to the rest for better clarity.
comet-java-client/src/main/java/ml/comet/experiment/impl/rest/AddExperimentTagsRest.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/rest/AddGraphRest.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/artifact/GetArtifactOptions.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/exception/CometApiException.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/exception/CometApiException.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/rest/ArtifactDto.java
Show resolved
Hide resolved
…p before continue with shutdown routine.
…for request inventory cleanup.
…) of the artifact failed to be uploaded.
comet-examples/src/main/java/ml/comet/examples/ArtifactExample.java
Outdated
Show resolved
Hide resolved
yaricom
commented
Dec 17, 2021
comet-java-client/src/main/java/ml/comet/experiment/impl/rest/OutputUpdate.java
Show resolved
Hide resolved
Lothiraldan
requested changes
Dec 20, 2021
comet-java-client/src/main/java/ml/comet/experiment/impl/BaseExperimentAsync.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/ArtifactImpl.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/BaseExperimentAsync.java
Show resolved
Hide resolved
…t. Fixed to use refactored Asset data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comet-java-client
ArtifactandArtifactBuilderinterfacesasset, addremote asset, and addassets folderto theArtifactcomet-examples
ArtifactExampleto demonstrate basic usage of the Comet artifact.