DT-436 adding tags to aws resources

[christopher-comet]

https://comet-ml.atlassian.net/browse/DT-436

This also includes edits to make the tfvars ready to go with defaults and updates the redis version.

[darenjacobs]

LGTM

[christopher-comet]

Ready for review. @darenjacobs @liyaka

Old

[christopher-comet]

There are a couple of modules wherein the resource explicitly sets tags.
eg. in terraform-aws-comet/modules/comet_s3/main.tf

resource "aws_s3_bucket" "comet_airflow_bucket" {
  count = var.enable_mpm_infra ? 1 : 0

  bucket = "comet-airflow-${local.suffix}"

  force_destroy = var.s3_force_destroy

  tags = {
    Name = "comet-airflow-${local.suffix}"
  }
}

In this situation the S3 bucket will only get the Name tag, and it will NOT inherit common_tags automatically because the tags block inside aws_s3_bucket is explicitly defined, and default_tags from providers.tf does not override manually set tags.

Therefore for these cases we need to merge the common_tags.

Stale review