Skip to content

Add option pass on NoCommitsFoundError #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datanrd opened this issue Mar 2, 2022 · 7 comments · Fixed by #25
Closed

Add option pass on NoCommitsFoundError #21

datanrd opened this issue Mar 2, 2022 · 7 comments · Fixed by #25

Comments

@datanrd
Copy link

datanrd commented Mar 2, 2022

If you use a change type like ci:, build:, docs:, style: or chore:, it won't bump the version unless you add it to the bump_pattern and bump_map. You may not want to bump the version for these change types. I propose adding
an option to allow pass on NoCommitsFoundError. In the exit codes documentation, it throws an error code of 3 when no commits are found. An option to allow pass on no commits found will allow for simpler workflows. For example, if I update the docs or other change types that don't necessitate a release, with an option like allow_no_commits I won't have to put parsing around the commit message to not run. With the this option runs the risks of swallowing unintentional errors.

@datanrd datanrd changed the title Add option to allow pass on NoCommitsFoundError Add option pass on NoCommitsFoundError Mar 2, 2022
@woile
Copy link
Member

woile commented Mar 3, 2022

We have planned a feature on commitizen directly that we'll try to implement soon:
commitizen-tools/commitizen#485

@Kurt-von-Laven
Copy link
Contributor

This would be great to have. I would guess that this issue makes the Commitizen action incompatible with Dependabot and similar automated upgrade tools that may routinely open pull requests that only upgrade development dependencies and don't imply a version bump. When I merge a pull request that doesn't imply a version bump, I have to remember to manually delete the subsequent failing Commitizen workflow run, or the build will misleadingly appear to be red after merging a passing pull request.

@woile
Copy link
Member

woile commented Apr 7, 2022

The PR is almost ready

@Kurt-von-Laven
Copy link
Contributor

I saw the aforementioned excellent feature released in Commitizen 2.24.0. Is there a way to pass --no-raise through to commitizen from this action, or does a new input need to be added?

@woile
Copy link
Member

woile commented Apr 29, 2022

Please review PR 🙏🏻

@woile woile closed this as completed in #25 May 4, 2022
@woile
Copy link
Member

woile commented Oct 11, 2022 via email

@Kurt-von-Laven
Copy link
Contributor

@woile, did you mean that reply for a different thread? --no-raise has been available via the action since May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants