Skip to content

Actor of pushing to branch should be configurable #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lleontop opened this issue Feb 3, 2023 · 3 comments · Fixed by #95
Closed

Actor of pushing to branch should be configurable #55

lleontop opened this issue Feb 3, 2023 · 3 comments · Fixed by #95

Comments

@lleontop
Copy link

lleontop commented Feb 3, 2023

Hi,

thanks for this action!
I think there is a problem when the PAT used in the token belongs to one user and the actual commit actor are different which causes errors during pushing of bump commit and tag.
So if the PAT in the workflow belongs to a bot user A and the actual commit happens from a human user B then if I understand correctly the url in entrypoint.sh will try to authenticate user B with token from A and this will cause a failure in pushing.

I think an input configuring the actual user in this url (defaulting to actor) should suffice. I can also create a PR for this if this solution makes sense!

Thanks!

@woile
Copy link
Member

woile commented Feb 3, 2023

A PR would be welcome, thanks!

fritz-trawa added a commit to fritz-trawa/commitizen-action that referenced this issue Dec 9, 2024
@fritz-trawa
Copy link
Contributor

We need this too so I just created a PR

@woile woile closed this as completed in #95 Dec 9, 2024
woile added a commit that referenced this issue Dec 9, 2024
…-should-be-configurable

feat(#55): add ACTOR input parameter
@woile
Copy link
Member

woile commented Dec 9, 2024

thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants