refactor(git): simplify tag logic #1507
Open
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Jun 8, 2025
commitizen/git.py
Outdated
|
|
||
| # according to https://git-scm.com/book/en/v2/Git-Basics-Tagging, | ||
| # we're not able to create lightweight tag with message. | ||
| # by adding message, we make it a annotated tags | ||
| return cmd.run(f'git tag {_opt} "{tag if _opt == "" or msg is None else msg}"') | ||
| option = "-s" if signed else "-a" |
There was a problem hiding this comment.
worth mentione the else case if for annotated
There was a problem hiding this comment.
added a comment.
Lee-W
added
the
pr-status: ready-to-merge
bearomorphism
force-pushed
the
refactor-tag
branch
from
f945d2b to
aece9a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1507 +/- ##
=============================================
- Coverage 97.87% 97.86% -0.01%
=============================================
Files 57 57
Lines 2677 2675 -2
=============================================
- Hits 2620 2618 -2
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
refactor-tag
branch
2 times, most recently
from
b5b5bca to
32de613
Compare
bearomorphism
force-pushed
the
refactor-tag
branch
from
32de613 to
a505d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist