-
-
Notifications
You must be signed in to change notification settings - Fork 280
feat(bump): add support to bumping local version #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bump): add support to bumping local version #303
Conversation
… local version instead of the public
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 96.62% 96.96% +0.34%
==========================================
Files 33 33
Lines 919 924 +5
==========================================
+ Hits 888 896 +8
+ Misses 31 28 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test for this change?
Sure! Doing shortly. |
@Lee-W here it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one typo need to be fixed. Other parts looks good to me 🎉 @woile Could you please double check whether everything's good 🙂
Fantastic, thanks! |
Description
This PR creates adds a new flag
--local-version
to thebump
command that allows bumping the local version only instead of the public release.PS: I haven't create the tests/updated the documentation just yet. will do after confirmation the code is suitable.
Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
The current behavior of the
bump
ignores the local version and only bumps the public version.This flag allows to bump only the local portion of the version like
Steps to Test This Pull Request
version = "5.6.0+0.0.1"
.--local-version
.Additional context
Issue: #302
References: Python 440 Local version