-
-
Notifications
You must be signed in to change notification settings - Fork 279
feat: add --no-raise to avoid raising error codes #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9cc174e
to
f3a8769
Compare
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
- Coverage 98.05% 97.85% -0.21%
==========================================
Files 39 39
Lines 1441 1539 +98
==========================================
+ Hits 1413 1506 +93
- Misses 28 33 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update documentation for it? How will the argument usage look like?
@Lee-W I'm wondering whether we should go for: cz -nr 1 -nr 2 bump or cz -nr 1,2,3 bump I think for github action would be easier to do the 2nd one and maybe it's simpler. What do you think? |
I like |
Updated docs and now it works with: cz -nr 1,2,3 cz -nr NO_INCREMENT,NO_COMMITS_FOUND Please test 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward seeing it landing 🤩🤩🤩 just some minor suggestions / questions, but feel free to merge it 💯
| InvalidCommandArgumentError | 18 | The argument provide to command is invalid (e.g. `cz check -commit-msg-file filename --rev-range master..`) | | ||
| InvalidConfigurationError | 19 | An error was found in the Commitizen Configuration, such as duplicates in `change_type_order` | | ||
| NotAllowed | 20 | `--incremental` cannot be combined with a `rev_range` | | ||
| NoneIncrementExit | 21 | The commits found are not elegible to be bumped | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat!
Now it sohuld be ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #485
Description
Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
Exit code would rise 0 instead.
Steps to Test This Pull Request
With no new commit run
For more than one:
Additional context