Skip to content

Relax runtime dependency specifications #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Relax runtime dependency specifications #684

merged 4 commits into from
Mar 18, 2023

Conversation

jakob-keller
Copy link
Contributor

Description

Relaxes overly strict runtime dependency specifications for semver packages.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Allows for commitizen to be installed alongside current versions of runtime dependencies.

Steps to Test This Pull Request

Additional context

Closes #683

@jakob-keller
Copy link
Contributor Author

argcomplete does not appear to claim semver compliance. I suggest we leave that dependency as it is. What do you think?

@jakob-keller
Copy link
Contributor Author

jakob-keller commented Mar 11, 2023

Support for Python 3.6 appears to be broken according to #607 and #665.

Do you want me to bump the required Python version to 3.7 as part of this PR? I think we should.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (a60a9de) 98.08% compared to head (f81f749) 98.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   98.08%   98.02%   -0.06%     
==========================================
  Files          40       40              
  Lines        1720     1723       +3     
==========================================
+ Hits         1687     1689       +2     
- Misses         33       34       +1     
Flag Coverage Δ
unittests 98.02% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/defaults.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jakob-keller jakob-keller marked this pull request as ready for review March 12, 2023 15:12
@jakob-keller jakob-keller marked this pull request as draft March 12, 2023 15:30
@jakob-keller jakob-keller marked this pull request as ready for review March 12, 2023 15:34
@woile woile merged commit 378a428 into commitizen-tools:master Mar 18, 2023
@jakob-keller jakob-keller deleted the dependencies branch March 18, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax version specification for dependencies following semver
2 participants