Skip to content

Commit bdb61df

Browse files
authored
Fixes #2238 scalebar added in map (#3511)
* scalebar added in map * changes reverted in .idea/Project.xml * magic numbers replaced with constants for scalebar * Default setting for scaling unit * Default setting for scalebar refresh interval * Reformatted code for adding scalebar * dimen values for scalebar params
1 parent af131a9 commit bdb61df

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ dependencies {
3838
implementation 'com.github.pedrovgs:renderers:3.3.3'
3939
implementation 'com.mapbox.mapboxsdk:mapbox-android-sdk:8.6.2'
4040
implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-localization-v8:0.11.0'
41+
implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-scalebar-v9:0.4.0'
4142
implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0'
4243
implementation 'com.dinuscxj:circleprogressbar:1.1.1'
4344
implementation 'com.karumi:dexter:5.0.0'

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
import com.mapbox.mapboxsdk.maps.MapboxMap;
5353
import com.mapbox.mapboxsdk.maps.Style;
5454
import com.mapbox.mapboxsdk.maps.UiSettings;
55+
import com.mapbox.pluginscalebar.ScaleBarOptions;
56+
import com.mapbox.pluginscalebar.ScaleBarPlugin;
5557
import com.pedrogomez.renderers.RVRendererAdapter;
5658

5759
import java.util.ArrayList;
@@ -239,8 +241,19 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
239241
.zoom(ZOOM_LEVEL)
240242
.build();
241243
mapBoxMap.setCameraPosition(cameraPosition);
242-
});
243244

245+
ScaleBarPlugin scaleBarPlugin = new ScaleBarPlugin(mapView, mapBoxMap);
246+
int color = isDarkTheme ? R.color.bottom_bar_light : R.color.bottom_bar_dark;
247+
ScaleBarOptions scaleBarOptions = new ScaleBarOptions(getContext())
248+
.setTextColor(color)
249+
.setTextSize(R.dimen.description_text_size)
250+
.setBarHeight(R.dimen.tiny_gap)
251+
.setBorderWidth(R.dimen.miniscule_margin)
252+
.setMarginTop(R.dimen.tiny_padding)
253+
.setMarginLeft(R.dimen.tiny_padding)
254+
.setTextBarMargin(R.dimen.tiny_padding);
255+
scaleBarPlugin.create(scaleBarOptions);
256+
});
244257
});
245258
}
246259

0 commit comments

Comments
 (0)