Skip to content

App displays images which have been deleted #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domdomegg opened this issue Jun 7, 2016 · 4 comments
Closed

App displays images which have been deleted #118

domdomegg opened this issue Jun 7, 2016 · 4 comments

Comments

@domdomegg
Copy link
Member

App displays entries for images that have been deleted, not sure what exactly we want to do about this.

I'd suggest just not showing them at all, however some may disagree saying it might be useful to see some info e.g. a much smaller bar with the file name followed by "(deleted)" or something.

404 responses are received when trying to get the images / their thumbnails (best to check image though, as thumbnail may just be wrong like #119)

@domdomegg
Copy link
Member Author

Screenshot of current behaviour:
screenshot_20160607-215458

@nicolas-raoul
Copy link
Member

I am fine either way.
Indeed, people who keep uploading selfies (there are not many such people, but there are sometimes) might benefit from learning that their image has been deleted.

@misaochan
Copy link
Member

I'm not sure if this has been done? And if not, do we want deleted contributions shown?

What about if we have an overlay that says "Deleted"?

@maskaravivek
Copy link
Member

I think the app is trying to skip deleted images. ContributionsSyncAdapter:onPerformSync

for (LogEventResult.LogEvent image : logEvents) {
                if (image.isDeleted()) {
                    // means that this upload was deleted.
                    continue;
                }
            ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants