Skip to content

Removing failed uploads from ContributionsList #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue Jul 20, 2016 · 8 comments
Closed

Removing failed uploads from ContributionsList #199

misaochan opened this issue Jul 20, 2016 · 8 comments

Comments

@misaochan
Copy link
Member

From andrea as:

Hi, usually I, from commons app, tap gallery and search in Google photos and dont crash immidiatly but when is uploading.
Often The uploading dont finish and i have a lot of upload not finish in the top of my list "non riuscito" how can i erase it?

Do we have a way for the user to remove the failed uploads from their Contributions list? If not, should we?

@nicolas-raoul
Copy link
Member

I have never seen such a feature.
I don't think it is very high priority though?
Especially if the first page is eventually replaced with a map of requested pictures around.

@tobias47n9e
Copy link
Member

I just ran into this problem while I had a bad internet connection. It would be good if the app would have a button to retry the upload.

@neslihanturan
Copy link
Collaborator

I think this issue is quite annonying, my proposed solution is:

  • If an upload failed
    • Check if we can still access to file to be uploaded. If we can, then display retry and cancel buttons
    • Do same operation on each time contributions list is loaded.

I think this issue is high priority from now on.

@misaochan
Copy link
Member Author

Check if we can still access to file to be uploaded. If we can, then display retry and cancel buttons

Sounds good. AFAIK retry does not usually work currently though, that would need to be fixed simultaneously.

Do same operation on each time contributions list is loaded.

How resource-intensive would this be?

@misaochan misaochan reopened this Nov 13, 2018
@neslihanturan
Copy link
Collaborator

neslihanturan commented Nov 13, 2018

Sounds good. AFAIK retry does not usually work currently though, that would need to be fixed simultaneously.

Yes this also needs to be fixed, but for some cases, retry is not event possible. So we need to cancel it automaticcally with a toast message.

How resource-intensive would this be?

I think we can listen when a new item is added to our db.

@neslihanturan
Copy link
Collaborator

neslihanturan commented Mar 11, 2019

This seems to be related with #118 , so closing the old issue. Sorry they are not same, the other one is about delete from server side.

Currently we have retry and delete buttons for failed uploads, they work well in general but they are still not very consistent.

@Rishavgupta12345
Copy link
Contributor

@nicolas-raoul This issue is pretty old and now we can easily remove the failed uploads , HENCE this issue is already solved

@nicolas-raoul
Copy link
Member

@Rishavgupta12345 You are right, there is now a button to remove failed uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants