Skip to content

[GCI Ideas] Remove unused imports from classes #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashk2000 opened this issue Nov 8, 2019 · 8 comments · Fixed by #3272
Closed

[GCI Ideas] Remove unused imports from classes #3201

yashk2000 opened this issue Nov 8, 2019 · 8 comments · Fixed by #3272

Comments

@yashk2000
Copy link
Contributor

Summary:

Currently, some classes contain unused imports. To improve code quality and make the app-building faster, these unused imports should be removed.

A few files that contain unused imports are:

  • SessionManager.java
  • BookmarkPicturesController.java
  • Bookmark.java
  • CacheController.java
  • CampaignsPresenter.java

Similarly, go through other classes and remove all unused imports. Unused imports show up in a dull gray color when the file is opened in android studio, unlike used imports which appear in white color.

Would you like to work on the issue?

Opening for GCI

@yashk2000
Copy link
Contributor Author

@neslihanturan @ashishkumar468 @nicolas-raoul please tell if this is a good task for GCI.

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Nov 9, 2019 via email

@GearGit
Copy link
Contributor

GearGit commented Nov 10, 2019

Summary:

Currently, some classes contain unused imports. To improve code quality and make the app-building faster, these unused imports should be removed.

A few files that contain unused imports are:

  • SessionManager.java
  • BookmarkPicturesController.java
  • Bookmark.java
  • CacheController.java
  • CampaignsPresenter.java

Similarly, go through other classes and remove all unused imports. Unused imports show up in a dull gray color when the file is opened in android studio, unlike used imports which appear in white color.

Would you like to work on the issue?

Opening for GCI

Can I work on this issue?

@yashk2000
Copy link
Contributor Author

@GearGit this is a GCI task. So if you are a GCI student, please wait till December 2nd to officially claim the task and then start working on it.
If you are not a GCI student, please go for a non-GCI issue :)

@nicolas-raoul
Copy link
Member

@GearGit Thanks for your comprehension :-)

@GearGit
Copy link
Contributor

GearGit commented Nov 22, 2019

No problem, I will revisit this issue after 2nd December.

@alcarazzam
Copy link
Contributor

Working on it

@yashk2000
Copy link
Contributor Author

All the best @m-alzam. Let me know if you face any difficulties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants