White font for place type search box and "x"

[nicolas-raoul]

I could not find 😂
It hides part of the map.

[neslihanturan]

Clicking the small "x" next to search area makes it for me. Does it work for you too @nicolas-raoul ?

[nicolas-raoul]

wow I could not see it lol by the way how about making the font white? same color as "place type" 🙂

…

On Fri, 29 Nov 2019, 22:17 neslihanturan, ***@***.***> wrote: Clicking the small "x" next to search area makes it for me. Does it work for you too @nicolas-raoul <https://github.com/nicolas-raoul> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3236?email_source=notifications&email_token=AAAYKBTLLGZYO4Y7UD4JCLTQWEI6FA5CNFSM4JS5MKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFO2YJI#issuecomment-559787045>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBSM273IUPM6DCUSRA3QWEI6FANCNFSM4JS5MKKQ> .

[chaytanyasinha]

Yes @nicolas-raoul even I feel that it should be in white

[chaytanyasinha]

May I do this

[neslihanturan]

Sure @chaytanyasinha , give a try, thanks! We especially want to have a white "x"

[chaytanyasinha]

The selected items also needs to be written in white?
@neslihanturan

[neslihanturan]

Displaying selected items is another issue, we should implement them separately. So for this issue just color of "x" button should be fine. By the way, you don't have any other assigned issues, right? We make one issue at a time.

[chaytanyasinha]

No @neslihanturan I don't have any issue on which I am currently working.Okay I'll change the color.

[nicolas-raoul]

Thanks @chaytanyasinha ! I think the "x" and also the text inside the place type search box (which says Bridge, museum, ho... in the screenshot above) should be made with the same font color as "Place type".

[chaytanyasinha]

Okay @nicolas-raoul I'll do it.

[chaytanyasinha]

@nicolas-raoul @neslihanturan I made the changes last night just after you assigned me but my ram is not working properly because of which I am not able to test the codes.
What should I do?

[chaytanyasinha]

@neslihanturan @nicolas-raoul should I send a pull request?

[nicolas-raoul]

Please send a pull request with the title "[WIP] White font for place type search box and x"
WIP means "Work In Progress"
Thanks :-)

[chaytanyasinha]

okay @nicolas-raoul I'll do it.

[neslihanturan]

@chaytanyasinha since the straightforward solution will not work for this issue (I also tried setting hint text color, I assume this is what you did too, am I right?) would be nicer to test it at least once before sending the PR. Is your issue with your ram permanent, or will be solved soon?

If it is not possible at all, I agree to Nicolas, please send it as [WIP]

[neslihanturan]

Additionally, this issue is one of our hot issues, see: #3256 so it would be amazing if you can send your [WIP] PR as soon as possible, so that, if it does not work I will have time to work on the same.

[chaytanyasinha]

No @neslihanturan RAM issue will be soon resolved,I'll try to test the codes now and will be sending the PR ASAP.

[chaytanyasinha]

Yes @neslihanturan I also tried using changing the hint color only.

[chaytanyasinha]

@neslihanturan @nicolas-raoul I have sent the pull request 2 days back with tag [WIP].I tried to test the codes but it was showing error "sdk files missing".I'll be thankful if you check it once for updating it.
Thanks.

[chaytanyasinha]

@neslihanturan please guide me where I am wrong I'll try to resolve the codes.

[neslihanturan]

Please see my reviews below your closed PR @chaytanyasinha . I think testing and seeing that your changes works is a must for sending a PR. so please focus on solving your issues with missing SDK filses, and make sure you can build the app with no issues. Then you can continue to contribute easier. Meanwhile I may have to send the PR for this issue, since it is on one of to do lists which has to be completed soon. But we have plenty other issues waiting for contributors:)

[chaytanyasinha]

Sure @neslihanturan I will soon resolve my problem of computer and will again start contributing to the community.
Earlier I was upset because of first PR rejection because I knew how to solve these type of issues but thanks for supporting.
I'll soon start contributing again

[neslihanturan]

Really no need to be upset, it is very normal to have some issues on your PR when your computer does not work properly and also SDK is not found. We need our tools to write code:)

[chaytanyasinha]

Okay @neslihanturan I will resolve the issue.

[chaytanyasinha]

@neslihanturan Can you please tell by what variable is the text defined which is there in the search box and the Cancel button.

[neslihanturan]

There are no variables defined in the Java code, you can create them by findView. Did you solved you issues with Android Studio? :)

[chaytanyasinha]

Actually @neslihanturan my ram was completely burnt from inside it will take few weeks to get new parts.That's why I am not active these days.
Extremely Sorry for delay.

[maskaravivek]

@chaytanyasinha Are you still working on this issue? If not, please let us know so that it can be reassigned to someone else. :)

[chaytanyasinha]

@maskaravivek No,I am not working on it due to some technical issues,I'll be back with contributing in few days.Please assign to someone else.
Regards

[albendz]

I can pick this up.

[maskaravivek]

Sure. Assigned to you. :)

[albendz]

@maskaravivek I'm unable to test the app due to a "Chain validation failed" error at the login page. Do you know what this is caused by? Tried on two different computers, multiple emulators, etc.

[maskaravivek]

Yes, I too faced the same issue while using the beta flavor of the app. It is being discussed here. #3320

You can build and use the prod flavor of the app for the time being.

[albendz]

Thanks, will do!