-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Upload limit is working even if I leave the upload limit edittext blank or if I press Cancel button #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ashishkumar0207 sir, Can I work on this? |
@vibhusharma101 It is yours, please feel free on posting updates on the same over here. |
@ashishkumar468 sir I am facing a little bit problem I am unable to login to the beta version of app. |
Hi @vibhusharma101, I have added a probable fix for #3320. Once that is merged, I am sure you will be able to login with your beta credentials and use the beta flavor of the app. |
ok sir @ashishkumar0207 |
@vibhusharma101 Login issue has been resolved, please take a pull from master. Feel free to post updates on this issue :) |
@ashishkumar468 sir incorrect username password coming even if I enter correct one |
@ashishkumar468 I don't think this issue has been fixed, the linked PR doesn't really display any error message nor does it fix the issue that even pressing "Cancel" saves the change. I'd be interested in working on this if it can be re-assigned. Thanks! |
@6point022 if you see any issues in @vibhusharma101's PR feel free to post your code review comments on the PR itself. :) |
@maskaravivek Hopefully migrations to AndroidX Pref #3521 will include this fix |
@maskaravivek I tested the master branch after #3521 merger and this issue is resolved, so we can close #3346 and #3362 |
Summary:
Upload limit is taking the first digit of last entered number a the upload limit if I am leaving upload limit edittext blank.
What did you expect the app to do, and what did you see instead?
I wanted app to show an toast displaying an error that upload limit edittext is empty.
Screen-shots:
Would you like to work on the issue?
I want to work on this issue.
@nicolas-raoul @maskaravivek
The text was updated successfully, but these errors were encountered: