Skip to content

[2.13-release] None of the filters work on Nearby list #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
misaochan opened this issue Apr 27, 2020 · 4 comments · Fixed by #3723
Closed

[2.13-release] None of the filters work on Nearby list #3720

misaochan opened this issue Apr 27, 2020 · 4 comments · Fixed by #3723
Assignees
@VitalyVPinchuk
Labels
bug nearby

Comments

@misaochan
Copy link
Member

misaochan commented Apr 27, 2020 •
edited
Loading

Summary:

The filters for place state and place type work for the map display, but changing them does not affect the list, even if you close and reopen the list.

This is especially bad for the "needs photo" place state as users will end up uploading a photo to a location that already has one, even though they have "needs photo" selected.

Device and Android version:

Samsung Galaxy S9 Android 10

Commons app version:

2.13-release branch, prodRelease

Would you like to work on the issue?

No
@VitalyVPinchuk
Copy link
Contributor

Hi @misaochan
Can I work on this?

@misaochan
Copy link
Member Author

@VitalyVPinchuk Yes, please feel free :)

@VitalyVPinchuk
Copy link
Contributor

Should I fork it from 2.13-release or master branch?

@ashishkumar468
Copy link
Collaborator

Hi @VitalyVPinchuk master should be fine, we will cherry-pick it from there for the release

VitalyVPinchuk added a commit to VitalyVPinchuk/apps-android-commons that referenced this issue Apr 30, 2020
@VitalyVPinchuk
Fixes commons-app#3720: None of the filters work on Nearby list
859037f
@misaochan misaochan mentioned this issue May 1, 2020
Closed
30 tasks
@VitalyVPinchuk VitalyVPinchuk mentioned this issue May 1, 2020
Merged
neslihanturan pushed a commit that referenced this issue May 4, 2020
@VitalyVPinchuk
Fixes #3720: None of the filters work on Nearby list (#3723)
6d687c3
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 10, 2020
@VitalyVPinchuk @ashishkumar468
Fixes commons-app#3720: None of the filters work on Nearby list (comm…
81558e4 
…ons-app#3723)
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 10, 2020
@VitalyVPinchuk @ashishkumar468
Fixes commons-app#3720: None of the filters work on Nearby list (comm…
3e7d777 
…ons-app#3723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VitalyVPinchuk VitalyVPinchuk

Labels
bug nearby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3720: None of the filters work on Nearby list VitalyVPinchuk/apps-android-commons
3 participants
@misaochan @ashishkumar468 @VitalyVPinchuk