Skip to content

Nearby: Pins loaded from cache sometimes disappear #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
savsch opened this issue Dec 20, 2024 · 0 comments · Fixed by #6057
Closed

Nearby: Pins loaded from cache sometimes disappear #6052

savsch opened this issue Dec 20, 2024 · 0 comments · Fixed by #6057
Assignees
@savsch
Labels
bug

Comments

@savsch
Copy link
Contributor

savsch commented Dec 20, 2024 •
edited
Loading

Summary

I seem to have made a mistake with #6047, which introduced this issue.

Tried to investigate for quite some time but couldn't figure out the cause. Fixing this one might take me some time.

We might consider reverting c891c2b or maybe not loading places from the cache in the meantime.

Steps to reproduce

  1. Open nearby
  2. Move to a place where most or all of the pins have been previously cached.
  3. Zoom into the place a little, or move the map slightly.

Expected behaviour

All pins are displayed.

Actual behaviour

Some cached pins disappear (see attached screen recording)

Commons app version

current main

Screen-shots

recording_2024-12-21_05.20.50.mp4

Would you like to work on the issue?

Yes
@savsch savsch added the bug label Dec 20, 2024
savsch added a commit to savsch/apps-android-commons that referenced this issue Dec 21, 2024
@savsch
Nearby Fix disappearing of pins loaded from cache
09115ef 
Fixes commons-app#6052
@savsch savsch mentioned this issue Dec 21, 2024
Merged
nicolas-raoul added a commit that referenced this issue Dec 21, 2024
@savsch @nicolas-raoul
Nearby: Fix disappearing of pins loaded from cache (#6052) (#6057)
4dd1605 
* Nearby Fix disappearing of pins loaded from cache

Fixes #6052

* Remove outdated tests

---------

Co-authored-by: Nicolas Raoul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savsch savsch

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nearby: Fix disappearing of pins loaded from cache (#6052) savsch/apps-android-commons
1 participant
@savsch