[WIP] Run androidTests in Travis #2897
Conversation
| @@ -110,7 +110,6 @@ android { | |||
| minSdkVersion 19 | |||
| targetSdkVersion 28 | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
| testInstrumentationRunnerArguments clearPackageData: 'true' | |||
There was a problem hiding this comment.
Will all tests pass if we don't clear data before every test?
There was a problem hiding this comment.
Yes, they all work fine now as we've removed the temperamental ones, and the emulator starts it from a clean state at the beginning.
|
@maskaravivek please can you have a look at fixing #2868 so this can be merged. |
|
@domdomegg I have fixed #2868. Let us try to get this PR merged. :) |
|
@domdomegg Is the PR ready for review? |
|
Don't think so, Travis still isn't building it :( https://travis-ci.com/domdomegg/apps-android-commons/builds/151255220 |
|
Yup, i had tried using your changes in #3298 but faced the same issue. |
|
This PR is WIP for long time, do you think we should keep it open @domdomegg , or do you think another solution will be needed for this task? |
|
We need to redo some of the UI test logic I think. Will require more changes. Closing for now. |
Description
Fixes #2226, #2823. Has Travis run all the android tests.
An example is here:
https://travis-ci.com/domdomegg/apps-android-commons/builds/108990409
@maskaravivek Due to #2868 this doesn't work on master - probably need your help with this. Having a look at #2829 the obvious cause is the removal of StringUtils but using alternatives just doesn't seem to work after that PR (e.g. even just checking if it's an empty string).Future plans
Ideally the androidTests can be separated from the unit tests for faster builds. I think this should be relatively easy once this is up and running on Travis. Relevant docs: https://docs.travis-ci.com/user/build-matrix/