On Logout, fetch the CSRF token #3173
Conversation
* use the CSRF token to make the logout post call * once both of these succeed, clear the local data
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## backend-overhaul #3173 +/- ##
===================================================
- Coverage 5.79% 5.77% -0.02%
===================================================
Files 257 257
Lines 11270 11308 +38
Branches 895 897 +2
===================================================
Hits 653 653
- Misses 10562 10600 +38
Partials 55 55
Continue to review full report at Codecov.
|
ashishkumar468
changed the title
| * Fetch the CSRF token to logout | ||
| */ | ||
| private void handleLogout() { | ||
| service = ServiceFactory.get(commonsWikiSite); |
There was a problem hiding this comment.
Move this to a separate class. ie LogoutClient
|
|
||
| progressDialog.show(); | ||
| disposable.add( | ||
| service.getCsrfToken() |
There was a problem hiding this comment.
Use @Named(NAMED_COMMONS_CSRF)
| /** | ||
| * Make the logout post call with the CSRF token fetched | ||
| */ | ||
| private void postLogoutApi(MwQueryResponse response) { |
There was a problem hiding this comment.
Move to LogoutClient or AuthClient
|
@ashishkumar468 have you opened a new PR for the same? |
|
@maskaravivek Yes, this branch somehow got very much away from backend-overhaul, after we recently synced backend-overhaul with master, so as the changes were small, I thought making a new one would be quicker :-) |
Fixes #3150 (comment)
Description (required)
Tests performed (required)
Tested prodDebug on Samsung S7 API 27