Skip to content

Fix compilation errors while trying to run instrumentation tests #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikehc
Copy link
Contributor

@mikehc mikehc commented Jun 27, 2020

Description (required)

Fixes Instrumentation Tests unable to run on device/emulator because the project fails to compile. Some classes changed names without updating the tests. Additionally there were some compat issues when calling Kotlin code from Java.

Some instrumentation tests are not passing. They need to be fixed but that is out of scope of what this PR is trying to fix.

Tests performed (required)

Tested betaDebug on Samsung S9 with API level 29.

@maskaravivek
Copy link
Member

Thanks for fixing the build @mikehc. :)

Also, it would be great if you could take a look at #3298. We are trying to run UI tests on Travis but are running into some issues.

@misaochan misaochan merged commit 7caf73f into commons-app:master Jun 29, 2020
@mikehc mikehc deleted the mikehc/fix-instrumentation-tests-build branch July 6, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants