Fixed bug "Copy to subsequent media" does not work if depicts Wikidata place #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Oct 31, 2022
| @@ -164,19 +164,29 @@ private void init() { | |||
|
|
|||
| if (callback.getIndexInViewFlipper(this) == 0) { | |||
| btnPrevious.setEnabled(false); | |||
|
|
|||
There was a problem hiding this comment.
Is this new line really needed?
| btnCopyToSubsequentMedia.setVisibility(View.GONE); | ||
| } else { | ||
|
|
||
| if (callback.getIndexInViewFlipper(this) != callback.getTotalNumberOfSteps()-4){ |
There was a problem hiding this comment.
Would you mind keeping the == and flipping the GONE/VISIBLE calls? Double-negations are confusing. Thanks!
nicolas-raoul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5057
What changes did you make and why?
The bug occurs if the user selects yes for “whether the pictures depict the place”, the button ‘btnCopyToSubsequentMedia’ sets its visibility to ‘GONE’, which conflicts the original visibility ‘VISIBLE’.
Tests performed (required)
Tested beta on Google pixel 6 with API level 30.