-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixed Clicking on edit photo shows default rotation #5575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by student
Unable to Build, Please take a pull from the main and make changes accordingly.
@shashankiitbhu, I am still facing an error
|
@kanahia1 For this you can just remove the folder for yue-hant. My review wasn't related to this, I was building the app after removing this, your pull request is failing to build even after removing this folder. Please try building it after removing this folder and you will see other errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last step seems problematic:
screen-20240324-193322.mp4
Oh, Looking into it! Will share PR asap ;) |
Did you get a chance to look at this, maybe? :-) |
Fixed the animation issue, but it landed me into another issue. Trying to fix it! WhatsApp.Video.2024-04-01.at.22.17.05_cc713800.mp4 |
Description (required)
Fixes #5502
What changes did you make and why?
Tests performed (required)
Tested prodDebug on Samsung S21 FE with API level 33.
Screenshots (for UI changes only)
WhatsApp.Video.2024-02-02.at.13.23.12_d63285c9.mp4