Partial fixes for errors and warnings reported by ./gradlew lint

app/src/main/AndroidManifest.xml

@@ -99,7 +99,6 @@
       android:exported="true"
       android:hardwareAccelerated="false"
       android:icon="@mipmap/ic_launcher"
-      android:label="@string/app_name"
       android:windowSoftInputMode="adjustResize">
       <intent-filter android:label="@string/intent_share_upload_label">
         <action android:name="android.intent.action.SEND" />
@@ -122,7 +121,7 @@
       android:name=".contributions.MainActivity"
       android:configChanges="screenSize|keyboard|orientation"
       android:icon="@mipmap/ic_launcher"
-      android:label="@string/app_name" />
+      />
     <activity
       android:name=".settings.SettingsActivity"
       android:label="@string/title_activity_settings" />

app/src/main/java/fr/free/nrw/commons/BaseMarker.kt

@@ -46,7 +46,7 @@ class BaseMarker {
         val drawable: Drawable = context.resources.getDrawable(drawableResId)
         icon =
             if (drawable is BitmapDrawable) {
-                (drawable as BitmapDrawable).bitmap
+                drawable.bitmap
             } else {
                 val bitmap =
                     Bitmap.createBitmap(

app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java

@@ -53,6 +53,7 @@
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.schedulers.Schedulers;
 import java.util.List;
+import java.util.Locale;
 import javax.inject.Inject;
 import javax.inject.Named;
 import org.osmdroid.tileprovider.tilesource.TileSourceFactory;
@@ -301,7 +302,8 @@ private void bindViews() {
         modifyLocationButton = findViewById(R.id.modify_location);
         removeLocationButton = findViewById(R.id.remove_location);
         showInMapButton = findViewById(R.id.show_in_map);
-        showInMapButton.setText(getResources().getString(R.string.show_in_map_app).toUpperCase());
+        showInMapButton.setText(getResources().getString(R.string.show_in_map_app).toUpperCase(
+            Locale.ROOT));
         shadow = findViewById(R.id.location_picker_image_view_shadow);
     }
 

app/src/main/java/fr/free/nrw/commons/Media.kt

@@ -3,6 +3,7 @@ package fr.free.nrw.commons
 import android.os.Parcelable
 import fr.free.nrw.commons.location.LatLng
 import fr.free.nrw.commons.wikidata.model.page.PageTitle
+import kotlinx.parcelize.IgnoredOnParcel
 import kotlinx.parcelize.Parcelize
 import java.util.Date
 import java.util.Locale
@@ -124,6 +125,7 @@ class Media constructor(
      * Gets the categories the file falls under.
      * @return file categories as an ArrayList of Strings
      */
+    @IgnoredOnParcel
     var addedCategories: List<String>? = null
         // TODO added categories should be removed. It is added for a short fix. On category update,
         //  categories should be re-fetched instead

app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsDao.java

@@ -1,5 +1,6 @@
 package fr.free.nrw.commons.bookmarks.items;
 
+import android.annotation.SuppressLint;
 import android.content.ContentProviderClient;
 import android.content.ContentValues;
 import android.database.Cursor;
@@ -134,6 +135,7 @@ public boolean findBookmarkItem(final String depictedItemID) {
      * @param cursor : Object for storing database data
      * @return DepictedItem
      */
+    @SuppressLint("Range")
     DepictedItem fromCursor(final Cursor cursor) {
         final String fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_NAME));
         final String description

app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsDao.java

@@ -1,5 +1,6 @@
 package fr.free.nrw.commons.bookmarks.locations;
 
+import android.annotation.SuppressLint;
 import android.content.ContentProviderClient;
 import android.content.ContentValues;
 import android.database.Cursor;
@@ -146,6 +147,7 @@ public boolean findBookmarkLocation(Place bookmarkLocation) {
         return false;
     }
 
+    @SuppressLint("Range")
     @NonNull
     Place fromCursor(final Cursor cursor) {
         final LatLng location = new LatLng(cursor.getDouble(cursor.getColumnIndex(Table.COLUMN_LAT)),

app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.java

@@ -1,5 +1,6 @@
 package fr.free.nrw.commons.bookmarks.pictures;
 
+import android.annotation.SuppressLint;
 import android.content.ContentProviderClient;
 import android.content.ContentValues;
 import android.database.Cursor;
@@ -150,6 +151,7 @@ public boolean findBookmark(Bookmark bookmark) {
         return false;
     }
 
+    @SuppressLint("Range")
     @NonNull
     Bookmark fromCursor(Cursor cursor) {
         String fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_MEDIA_NAME));

app/src/main/java/fr/free/nrw/commons/category/CategoryClient.kt

@@ -124,7 +124,7 @@ class CategoryClient
                 }.map {
                     it
                         .filter { page ->
-                            page.categoryInfo() == null || !page.categoryInfo().isHidden
+                            !page.categoryInfo().isHidden
                         }.map {
                             CategoryItem(
                                 it.title().replace(CATEGORY_PREFIX, ""),

app/src/main/java/fr/free/nrw/commons/category/CategoryDao.java

@@ -1,5 +1,6 @@
 package fr.free.nrw.commons.category;
 
+import android.annotation.SuppressLint;
 import android.content.ContentProviderClient;
 import android.content.ContentValues;
 import android.database.Cursor;
@@ -111,6 +112,7 @@ List<CategoryItem> recentCategories(int limit) {
     }
 
     @NonNull
+    @SuppressLint("Range")
     Category fromCursor(Cursor cursor) {
         // Hardcoding column positions!
         return new Category(

app/src/main/java/fr/free/nrw/commons/contributions/WikipediaInstructionsDialogFragment.kt

@@ -22,7 +22,7 @@ class WikipediaInstructionsDialogFragment : DialogFragment() {
     ) = DialogAddToWikipediaInstructionsBinding
         .inflate(inflater, container, false)
         .apply {
-            val contribution: Contribution? = arguments!!.getParcelable(ARG_CONTRIBUTION)
+            val contribution: Contribution? = requireArguments().getParcelable(ARG_CONTRIBUTION)
             tvWikicode.setText(contribution?.media?.wikiCode)
             instructionsCancel.setOnClickListener { dismiss() }
             instructionsConfirm.setOnClickListener {

app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt

@@ -237,7 +237,7 @@ class DescriptionEditActivity :
     ) {
         try {
             descriptionEditHelper
-                ?.addDescription(
+                .addDescription(
                     applicationContext,
                     media,
                     updatedWikiText,
@@ -250,7 +250,7 @@ class DescriptionEditActivity :
                     )
                 }
         } catch (e: InvalidLoginTokenException) {
-            val username: String? = sessionManager?.userName
+            val username: String? = sessionManager.userName
             val logoutListener =
                 CommonsApplication.BaseLogoutListener(
                     this,
@@ -268,7 +268,7 @@ class DescriptionEditActivity :
         for (mediaDetail in uploadMediaDetails) {
             try {
                 compositeDisposable.add(
-                    descriptionEditHelper!!
+                    descriptionEditHelper
                         .addCaption(
                             applicationContext,
                             media,

app/src/main/java/fr/free/nrw/commons/edit/TransformImageImpl.kt

@@ -65,7 +65,6 @@ class TransformImageImpl : TransformImage {
             } catch (e: LLJTranException) {
                 Timber.tag("Error").d(e)
                 return null
-                false
             }
 
         if (rotated) {

app/src/main/java/fr/free/nrw/commons/explore/ExploreFragment.java

@@ -22,6 +22,7 @@
 import fr.free.nrw.commons.utils.ActivityUtils;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import javax.inject.Inject;
 import javax.inject.Named;
 
@@ -112,13 +113,13 @@ public void setTabs() {
         mobileRootFragment = new ExploreListRootFragment(mobileArguments);
         mapRootFragment = new ExploreMapRootFragment(mapArguments);
         fragmentList.add(featuredRootFragment);
-        titleList.add(getString(R.string.explore_tab_title_featured).toUpperCase());
+        titleList.add(getString(R.string.explore_tab_title_featured).toUpperCase(Locale.ROOT));
 
         fragmentList.add(mobileRootFragment);
-        titleList.add(getString(R.string.explore_tab_title_mobile).toUpperCase());
+        titleList.add(getString(R.string.explore_tab_title_mobile).toUpperCase(Locale.ROOT));
 
         fragmentList.add(mapRootFragment);
-        titleList.add(getString(R.string.explore_tab_title_map).toUpperCase());
+        titleList.add(getString(R.string.explore_tab_title_map).toUpperCase(Locale.ROOT));
 
         ((MainActivity)getActivity()).showTabs();
         ((BaseActivity) getActivity()).getSupportActionBar().setDisplayHomeAsUpEnabled(false);

app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.java

@@ -28,6 +28,7 @@
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
+import java.util.Locale;
 import java.util.concurrent.TimeUnit;
 import javax.inject.Inject;
 import timber.log.Timber;
@@ -95,11 +96,11 @@ public void setTabs() {
         searchDepictionsFragment = new SearchDepictionsFragment();
         searchCategoryFragment= new SearchCategoryFragment();
         fragmentList.add(searchMediaFragment);
-        titleList.add(getResources().getString(R.string.search_tab_title_media).toUpperCase());
+        titleList.add(getResources().getString(R.string.search_tab_title_media).toUpperCase(Locale.ROOT));
         fragmentList.add(searchCategoryFragment);
-        titleList.add(getResources().getString(R.string.search_tab_title_categories).toUpperCase());
+        titleList.add(getResources().getString(R.string.search_tab_title_categories).toUpperCase(Locale.ROOT));
         fragmentList.add(searchDepictionsFragment);
-        titleList.add(getResources().getString(R.string.search_tab_title_depictions).toUpperCase());
+        titleList.add(getResources().getString(R.string.search_tab_title_depictions).toUpperCase(Locale.ROOT));
 
         viewPagerAdapter.setTabData(fragmentList, titleList);
         viewPagerAdapter.notifyDataSetChanged();

app/src/main/java/fr/free/nrw/commons/explore/categories/media/CategoriesMediaFragment.kt

@@ -18,6 +18,6 @@ class CategoriesMediaFragment : PageableMediaFragment() {
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated("$CATEGORY_PREFIX${arguments!!.getString("categoryName")!!}")
+        onQueryUpdated("$CATEGORY_PREFIX${requireArguments().getString("categoryName")!!}")
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/categories/parent/ParentCategoriesFragment.kt

@@ -21,6 +21,6 @@ class ParentCategoriesFragment : PageableCategoryFragment() {
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated("$CATEGORY_PREFIX${arguments!!.getString("categoryName")!!}")
+        onQueryUpdated("$CATEGORY_PREFIX${requireArguments().getString("categoryName")!!}")
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/categories/sub/SubCategoriesFragment.kt

@@ -20,6 +20,6 @@ class SubCategoriesFragment : PageableCategoryFragment() {
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated("$CATEGORY_PREFIX${arguments!!.getString("categoryName")!!}")
+        onQueryUpdated("$CATEGORY_PREFIX${requireArguments().getString("categoryName")!!}")
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/depictions/child/ChildDepictionsFragment.kt

@@ -13,13 +13,13 @@ class ChildDepictionsFragment : PageableDepictionsFragment() {
     override val injectedPresenter
         get() = presenter
 
-    override fun getEmptyText(query: String) = getString(R.string.no_child_classes, arguments!!.getString("wikidataItemName")!!)
+    override fun getEmptyText(query: String) = getString(R.string.no_child_classes, requireArguments().getString("wikidataItemName")!!)
 
     override fun onViewCreated(
         view: View,
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated(arguments!!.getString("entityId")!!)
+        onQueryUpdated(requireArguments().getString("entityId")!!)
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/depictions/media/DepictedImagesFragment.kt

@@ -17,6 +17,6 @@ class DepictedImagesFragment : PageableMediaFragment() {
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated(arguments!!.getString("entityId")!!)
+        onQueryUpdated(requireArguments().getString("entityId")!!)
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/depictions/parent/ParentDepictionsFragment.kt

@@ -13,13 +13,13 @@ class ParentDepictionsFragment : PageableDepictionsFragment() {
     override val injectedPresenter
         get() = presenter
 
-    override fun getEmptyText(query: String) = getString(R.string.no_parent_classes, arguments!!.getString("wikidataItemName")!!)
+    override fun getEmptyText(query: String) = getString(R.string.no_parent_classes, requireArguments().getString("wikidataItemName")!!)
 
     override fun onViewCreated(
         view: View,
         savedInstanceState: Bundle?,
     ) {
         super.onViewCreated(view, savedInstanceState)
-        onQueryUpdated(arguments!!.getString("entityId")!!)
+        onQueryUpdated(requireArguments().getString("entityId")!!)
     }
 }

app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java

@@ -1,5 +1,6 @@
 package fr.free.nrw.commons.explore.recentsearches;
 
+import android.annotation.SuppressLint;
 import android.content.ContentProviderClient;
 import android.content.ContentValues;
 import android.database.Cursor;
@@ -178,6 +179,7 @@ public List<String> recentSearches(int limit) {
      * @return RecentSearch object
      */
     @NonNull
+    @SuppressLint("Range")
     RecentSearch fromCursor(Cursor cursor) {
         // Hardcoding column positions!
         return new RecentSearch(

app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.java

@@ -15,6 +15,7 @@
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
 import fr.free.nrw.commons.explore.SearchActivity;
 import java.util.List;
+import java.util.Locale;
 import javax.inject.Inject;
 
 
@@ -90,7 +91,7 @@ private void setDeleteRecentPositiveButton(@NonNull final Context context,
     private void showDeleteAlertDialog(@NonNull final Context context, final int position) {
         new AlertDialog.Builder(context)
             .setMessage(R.string.delete_search_dialog)
-            .setPositiveButton(getString(R.string.delete).toUpperCase(),
+            .setPositiveButton(getString(R.string.delete).toUpperCase(Locale.ROOT),
                 ((dialog, which) -> setDeletePositiveButton(context, dialog, position)))
             .setNegativeButton(android.R.string.cancel, null)
             .create()

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -600,8 +600,8 @@ private void updateToDoWarning() {
         // Check if the presented category is about need of category
         if (categoriesPresent) {
             for (String category : media.getCategories()) {
-                if (category.toLowerCase().contains(CATEGORY_NEEDING_CATEGORIES) ||
-                    category.toLowerCase().contains(CATEGORY_UNCATEGORISED)) {
+                if (category.toLowerCase(Locale.ROOT).contains(CATEGORY_NEEDING_CATEGORIES) ||
+                    category.toLowerCase(Locale.ROOT).contains(CATEGORY_UNCATEGORISED)) {
                     categoriesPresent = false;
                 }
                 break;