Skip to content

Migrated navtab module from Java to Kotlin #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2024
Merged

Migrated navtab module from Java to Kotlin #5965

merged 3 commits into from
Nov 27, 2024

Conversation

Saifuddin53
Copy link
Contributor

Fixes: #5961
Part of: #5928

@Saifuddin53 Saifuddin53 marked this pull request as ready for review November 27, 2024 09:56
neeldoshii
neeldoshii reviewed Nov 27, 2024
View reviewed changes
app/src/main/java/fr/free/nrw/commons/navtab/MoreBottomSheetFragment.kt Outdated
@Inject
lateinit var commonsLogSender: CommonsLogSender

private lateinit var moreProfile: TextView
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed and no need to used lateinit or declare variable when we are on viewbinding we can use kotlin advantage over here

@neeldoshii
Copy link
Contributor

Note : I haven't tested your PR.

From the code its seem good just one issue, always make viewbinding null as it can lead to memory leaks

override fun onDestroyView() { 
    super.onDestroyView()    
    _binding = null 
}

@Saifuddin53
Copy link
Contributor Author

Thanks for your feedback! 🙂

nicolas-raoul
nicolas-raoul approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, thanks!

@nicolas-raoul nicolas-raoul merged commit 2380230 into commons-app:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neeldoshii neeldoshii neeldoshii left review comments

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration of navtab module to Kotlin
3 participants
@Saifuddin53 @neeldoshii @nicolas-raoul