Skip to content

Fix #6054: Rename SAVEPROGRESSDAILOG to SAVEPROGRESSDIALOG #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Fix #6054: Rename SAVEPROGRESSDAILOG to SAVEPROGRESSDIALOG #6058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ class LoginActivity : AccountAuthenticatorActivity() {

override fun onSaveInstanceState(outState: Bundle) {
// if progressDialog is visible during the configuration change then store state as true else false so that
// we maintain visibility of progressDailog after configuration change
// we maintain visibility of progressDialog after configuration change
if (progressDialog != null && progressDialog!!.isShowing) {
outState.putBoolean(saveProgressDailog, true)
outState.putBoolean(saveProgressDialog, true)
} else {
outState.putBoolean(saveProgressDailog, false)
outState.putBoolean(saveProgressDialog, false)
}
outState.putString(
saveErrorMessage,
Expand All @@ -206,7 +206,7 @@ class LoginActivity : AccountAuthenticatorActivity() {
super.onRestoreInstanceState(savedInstanceState)
binding!!.loginUsername.setText(savedInstanceState.getString(saveUsername))
binding!!.loginPassword.setText(savedInstanceState.getString(savePassword))
if (savedInstanceState.getBoolean(saveProgressDailog)) {
if (savedInstanceState.getBoolean(saveProgressDialog)) {
performLogin()
}
val errorMessage = savedInstanceState.getString(saveErrorMessage)
Expand Down Expand Up @@ -396,7 +396,7 @@ class LoginActivity : AccountAuthenticatorActivity() {
fun startYourself(context: Context) =
context.startActivity(Intent(context, LoginActivity::class.java))

const val saveProgressDailog: String = "ProgressDailog_state"
const val saveProgressDialog: String = "ProgressDialog_state"
const val saveErrorMessage: String = "errorMessage"
const val saveUsername: String = "username"
const val savePassword: String = "password"
Expand Down