Nearby: No longer keeps loading until timeout when map is zoomed out #6070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fantastic! I am trying it now. |
nicolas-raoul
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Fantastic work, Nearby is now really convenient to use even when checking remote places!
After browsing the map for 10 minutes (not doing anything else such as uploads) the app becomes slower and slower, so there might be some memory issues. But it is definitely a huge improvement compared to previous map slowliness.
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6044
Put briefly, the map now only searches in up to 300km radius centered on the screen's center.
The change wasnn't that simple, as loading the list of items even for a 50km radius can result in timeout for some locations, so I implemented an algorithm based on binary search to figure out the appropriate radius to list items inside, by first making some COUNT queries. Also, the centermost pins now appear on top.
Tests performed (required)
Tested BetaDebug on Medium Phone AVD and a Physical Device with API levels 34 and 33 respectively.
Screenshots (for UI changes only)
recording_2024-12-24_03.18.25.mp4