Skip to content

Migrated media/zoomControllers package to kotlin #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2025

Conversation

Saifuddin53
Copy link
Contributor

Parent issue: #5928

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ashamed to say I am not sure where these classes are used... do you know?

Maybe:

  • In the custom picker
  • In the upload wizard

@Saifuddin53
Copy link
Contributor Author

Hii @nicolas-raoul, we are using these classes in the custom picker to view an image in full-screen mode with features like zoom and swap gestures.
However, some classes like MultiZoomableControllerListener and MultiGestureListener haven't been used.

@rohit9625
Copy link
Contributor

rohit9625 commented Feb 26, 2025

I guess now the second workflow is running upon the success of the first workflow. Is the issue #6207 still relevant?

Edited: But why it's not in other PRs?

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoom and full-screen in custom picker still working as usual, thanks!

@nicolas-raoul nicolas-raoul merged commit 3032270 into commons-app:main Mar 8, 2025
1 check passed
Copy link

github-actions bot commented Mar 8, 2025

✅ Generated APK variants!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants