Skip to content

Outline - Remove app/components/Fade.ts (#3831) #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ecdfeaa2
Copy link

✍️ Description

The new version of Outline replaces the app/components/Fade.ts by app/components/Fade.tsx in outline/outline#8594. Fade.ts must be deleted to allow yarn build to resolve the tsx file instead.

🔗 Related PR / Issue

Link: #3831

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)

@ecdfeaa2 ecdfeaa2 requested a review from a team as a code owner April 11, 2025 17:01
@github-actions github-actions bot added bugfix update script A change that updates a script labels Apr 11, 2025
@michelroegl-brunner
Copy link
Member

This feels like a dirty fix tbh.
Prob. a better way would be to delete the whole app except userdata/settings.

But i/someone would have to look deeper into this.

@tremor021
Copy link
Member

tremor021 commented Apr 12, 2025

Yea, i will most likely just nuke the app and install fresh...

The script needs a rework anyway, since install instructions look different

@tremor021 tremor021 mentioned this pull request Apr 12, 2025
2 tasks
@tremor021 tremor021 closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants