Skip to content

Adding Blog Functionality and New Blog Posts #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuillPusher
Copy link
Contributor

@QuillPusher QuillPusher commented Mar 17, 2024

  • Preparing to add multiple Blog Posts (including Xeus-Cpp) that I've gathered info on. Will also share to LinkedIn.

  • Added blog.html layout and blog.md page to add Blog functionality

  • Reformatted existing articles to work with default blog functionality (file names, dates, excerpts, etc.)

  • moved articles from "_pages/blogs" to "_posts" as per standard Jekyll practice (this helps generate default variables like post.url)

  • moved articles still work with old link, so linkbacks will not be broken (tested)

  • Did not add "Blog" menu to Home page navigation, will do that as part of Front Page Customization PR

  • Note: I found that following images were missing on Fred's blog (cc1.gif, cc2.gif, tcc.gif). I have added screenshots from his presentation for now and emailed him for actual moving GIF files that show Code Completion demo

@QuillPusher QuillPusher force-pushed the Add_Blogs_Page_And_Nav branch from 43c1794 to 5551437 Compare March 17, 2024 22:33
@QuillPusher QuillPusher changed the title Adding Blog Functionality for Planned Blog Posts Adding Blog Functionality and New Blog Posts Mar 17, 2024
@davidlange6
Copy link
Contributor

are the images being added here not already part of the website?

@QuillPusher
Copy link
Contributor Author

QuillPusher commented Mar 20, 2024

@davidlange6
No, this is how it looks on my localhost after making the changes. I just shared these images to show how this change will reflect on the website after the merge

@davidlange6
Copy link
Contributor

@QuillPusher
Copy link
Contributor Author

just found that the previous images are from a "Blog Draft" page that is not rendered anywhere on the website.

4f92a92#diff-f97301cb74fc1a8f69b28c9b1112daa77c8ec91d44d2ba2429a63420348ef279

@QuillPusher
Copy link
Contributor Author

I suggest that we let my changes go in as they are, since the image files are named logically, based on blog post name. Also I formatted the images to look better with the rest of the content.

The existing images and the "_pages/blog_post.md" can perhaps be removed in a separate PR, along with other dead areas of the website that are not rendered anywhere

@vgvassilev
Copy link
Contributor

That makes the repository bigger and the deployment of the website unnecessarily slower. Even if we delete these files afterwords they still contribute to the overall size as they are present in the repository history.

@davidlange6
Copy link
Contributor

and here is where they are used on the website...
https://compiler-research.org/interactive_cpp
best not to duplicate content

@QuillPusher
Copy link
Contributor Author

On a closer look the older images are inconsistent.

  • There is one image missing (cling-2020-12-21-figure3.png).
  • One of them is a PNG instead of a GIF (cling-2020-12-21-figure9.gif/figure10.png) which defeats the purpose
  • There's another one that's different from the original image (cling-2020-12-21-figure1.png/figure3.png).
  • Also some of the older images are lower resolution.

Please let me know if I should revert to older images, because then that would require me deleting some images and adding some images anyway.

@vgvassilev
Copy link
Contributor

On a closer look the older images are inconsistent.

* There is **one image missing** (cling-2020-12-21-figure3.png).

Adding this should be fine.

* One of them is a **PNG instead of a GIF** (cling-2020-12-21-figure9.gif/figure10.png) which defeats the purpose

Those are two different items then and adding the gif is probably fine.

* There's another one that's **different from the original image** (cling-2020-12-21-figure1.png/figure3.png).

Let's replace the wrong image.

* Also some of the older images are **lower resolution**.

Let's replace the lower resolution images with the higher resolution ones.

Please let me know if I should revert to older images, because then that would require me deleting some images and adding some images anyway.

We should update the ones that are crappy and add the ones that are not duplicated.

@QuillPusher QuillPusher marked this pull request as draft March 20, 2024 14:40
- created a `blog.html` Layout (used by blog.md)

- created a `blog.md` page (main blog page, where excerpts of blogs are listed)

- moved existing blog posts from `_pages\blogs` to `_posts` as per standard jekyll practice (this makes available several variables like `post.url`)

- added 'date' parameter to existing blog posts' front matter to use for blog sorting. Added 'title', 'excerpt', etc. as well.

- removed additional posts and images (will be a separate PR)
@QuillPusher QuillPusher force-pushed the Add_Blogs_Page_And_Nav branch from 73d14a6 to 454e6d6 Compare March 20, 2024 15:30
@QuillPusher QuillPusher marked this pull request as ready for review March 20, 2024 15:38
@QuillPusher
Copy link
Contributor Author

QuillPusher commented Mar 20, 2024

Please ignore previous messages, full summary below: 🚀 🚀 🚀

  • created a blog.html Layout (used by blog.md)

  • created a blog.md page (main blog page, where excerpts of blogs are listed)

  • moved existing blog posts from _pages\blogs to _posts as per standard jekyll practice (this makes available several variables like post.url)

  • added date parameter to existing blog posts' front matter to use for blog sorting.

  • Changed Layout to post for blog posts (uses the existing post.html layout. I have tested it, the output looks OK).

  • Added 'title' and 'excerpt' in front matter to display on main Blog page (otherwise they would have been auto created based on file name and first paragraph)

  • removed additional posts and images (will be a separate PR)

  • Will add a 'how to add a blog entry' guide separately as part of a new 'contribution guide'.

BLOG
Blog

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@davidlange6 davidlange6 merged commit 6538a3a into compiler-research:master Mar 25, 2024
@QuillPusher QuillPusher deleted the Add_Blogs_Page_And_Nav branch March 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants