-
Notifications
You must be signed in to change notification settings - Fork 56
Adding Blog Functionality and New Blog Posts #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Blog Functionality and New Blog Posts #156
Conversation
43c1794
to
5551437
Compare
are the images being added here not already part of the website? |
@davidlange6 |
eg they are here already, no |
just found that the previous images are from a "Blog Draft" page that is not rendered anywhere on the website. 4f92a92#diff-f97301cb74fc1a8f69b28c9b1112daa77c8ec91d44d2ba2429a63420348ef279 |
I suggest that we let my changes go in as they are, since the image files are named logically, based on blog post name. Also I formatted the images to look better with the rest of the content. The existing images and the "_pages/blog_post.md" can perhaps be removed in a separate PR, along with other dead areas of the website that are not rendered anywhere |
That makes the repository bigger and the deployment of the website unnecessarily slower. Even if we delete these files afterwords they still contribute to the overall size as they are present in the repository history. |
and here is where they are used on the website... |
On a closer look the older images are inconsistent.
Please let me know if I should revert to older images, because then that would require me deleting some images and adding some images anyway. |
Adding this should be fine.
Those are two different items then and adding the gif is probably fine.
Let's replace the wrong image.
Let's replace the lower resolution images with the higher resolution ones.
We should update the ones that are crappy and add the ones that are not duplicated. |
- created a `blog.html` Layout (used by blog.md) - created a `blog.md` page (main blog page, where excerpts of blogs are listed) - moved existing blog posts from `_pages\blogs` to `_posts` as per standard jekyll practice (this makes available several variables like `post.url`) - added 'date' parameter to existing blog posts' front matter to use for blog sorting. Added 'title', 'excerpt', etc. as well. - removed additional posts and images (will be a separate PR)
73d14a6
to
454e6d6
Compare
Please ignore previous messages, full summary below: 🚀 🚀 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Preparing to add multiple Blog Posts (including Xeus-Cpp) that I've gathered info on. Will also share to LinkedIn.
Added blog.html layout and blog.md page to add Blog functionality
Reformatted existing articles to work with default blog functionality (file names, dates, excerpts, etc.)
moved articles from "_pages/blogs" to "_posts" as per standard Jekyll practice (this helps generate default variables like post.url)
moved articles still work with old link, so linkbacks will not be broken (tested)
Did not add "Blog" menu to Home page navigation, will do that as part of Front Page Customization PR
Note: I found that following images were missing on Fred's blog (cc1.gif, cc2.gif, tcc.gif). I have added screenshots from his presentation for now and emailed him for actual moving GIF files that show Code Completion demo