Front page layout four #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuillPusher
force-pushed
the
frontPageLayoutFour
branch
from
20bee79 to
3fe1eac
Compare
|
@davidlange6 requested review changes made:
|
|
|
looks basically good to me.
|
|
review changes made. YML Format:
widgets |
- changed navbar color in main.css - added hero/jumbotron/Splash section - Splash Screen/Home Page Text updated as per review - About Page created to move extra content from home page - added cards/thumbnails to link to projects - Cards color and order updated - simplified and realigned youtube preview - Custom Button CSS added - Youtube section miniaturized and simplified - News section height reduced to bottom half, tweaked to match card/carousel edges - Added "Blog" to main navigation bar (blogs added in separate PR)
- added 4 fixed height boxes showing the following timelines: - Project Meetings - Recent News - Open Projects - Team Meetings - Updated `homelay.html` to add new boxes - updated `news.html` and added similar `open-projects`, `project-meetings` and `team-meetings` layouts to make up the timeline boxes - removed `scroll` functionality to make the boxes uniform - Had to reformat the `standing_meetings.yml`, since it was only considering it as one news item. - Also had to edit `date` parameter to enable sorting. - Finally, moved the `updates` link to meeting notes doc outside the `agenda` since it was messing with the sorting (error: can't sort null date) - removed an extra space ( ) from `team_meetings` page that was messing up the layout
- Separated News from Release - Added new "releases" YML, Include and a Markdown page to list releases - Added Releases timeline on front page (`homelay.html`) - reverted formatting changes to `standing_meetings.yml` since it is no longer used for front page timeline - updated permalink on AllNews page to follow the same convention as other pages
reverted changes to `team_meetings.md` removed `team_meetings.html` include file since no longer used removed backup files
date format fixed codebase and version separate keys for Releases headings fixed
vgvassilev
force-pushed
the
frontPageLayoutFour
branch
from
6d9bb75 to
b406626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a fork built on top of the Front Page Layout already created for PR157. Following are only the changes made after that PR
Important Note: If this PR is merged, there is no need to merge PR115!
Changes in this PR:
Multiple News Timelines POC - Front Page Layout 4
added 4 fixed height boxes showing the following timelines:
Updated
homelay.htmlto add new boxesupdated
news.htmland added similaropen-projects,project-meetingsandteam-meetingslayouts to make up the timeline boxesremoved
scrollfunctionality to make the boxes uniformHad to reformat the
standing_meetings.yml, since it was only considering it as one news item.Also had to edit
dateparameter to enable sorting.Finally, moved the
updateslink to meeting notes doc outside theagendasince it was messing with the sorting (error: can't sort null date)removed an extra space from
team_meetingspage that was messing up the layout