RISCV: improve readablity of RISCV disassembler #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the bit-extraction operations with a helper template type `bits` which takes two template parameters to indicate the bits to extract. This improves the readability and maintainability of the RISCV disassembler. The idea itself was something that was suggested by @dmlockhart in #47. This noticably improves the ability to cross-reference the RISCV ISA specification.
|
@dmlockhart - I don't think that its valuable to try to write something to concatenate the bits. The compiler doesn't fare very well with that: https://godbolt.org/z/csjsj9xjv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the bit-extraction operations with a helper template type
bitswhichtakes two template parameters to indicate the bits to extract. This improves
the readability and maintainability of the RISCV disassembler. The idea itself
was something that was suggested by @dmlockhart in #47. This noticably improves
the ability to cross-reference the RISCV ISA specification.