Skip to content

add kompose to the list of projects using compose-go #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

add kompose to the list of projects using compose-go #343

merged 1 commit into from
Jan 12, 2023

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Jan 12, 2023

No description provided.

@Lctrs Lctrs requested a review from ndeloof as a code owner January 12, 2023 22:54
@glours
Copy link
Collaborator

glours commented Jan 12, 2023

Hello @Lctrs
You need to sign-off your commit otherwise we won't be able to approve and merge your PR

glours
glours approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 8a78100 into compose-spec:master Jan 12, 2023
@ndeloof
Copy link
Collaborator

ndeloof commented Jan 13, 2023

Congrats for kubernetes/kompose#1547 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lctrs @glours @ndeloof