Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable CA certs for fetching FROM images #2

Closed
vito opened this issue Aug 27, 2019 · 1 comment · Fixed by #52
Closed

Configurable CA certs for fetching FROM images #2

vito opened this issue Aug 27, 2019 · 1 comment · Fixed by #52

Comments

@vito
Copy link
Member

vito commented Aug 27, 2019

Dependent on moby/moby#38303

Devil's advocate for not implementing this: there is overlap with the registry-image resource once it supports TLS configuration and once #1 lands. Should we encourage explicitly tracking FROM images as resources instead of supporting the same overlapping feature set? Tasks shouldn't be fetching things willy-nilly anyway. Tracking it as a resource would provide caching and explicit version management.

vito added a commit that referenced this issue Jan 8, 2021
This adds 'image args', configurable with IMAGE_ARG_* - similar to
BUILD_ARG_*, only the value points to an image tarball.

The image tarball will be loaded and served by a local registry, and a
reference to the image in the local registry will be provided as the
build arg.

To use this, you must modify your Dockerfile like so:

  ARG base_image=ubuntu
  FROM ${base_image}

Then, when running oci-build-task, specify:

  params:
    IMAGE_ARG_base_image: ubuntu/image.tar

This will remain forward compatible if we ever switch to Kaniko (#46),
which would also require using build args as Kaniko image caching
requires a full digest to be specified in FROM.

fixes #1
closes #2
closes #3
closes #14

Signed-off-by: Alex Suraci <[email protected]>
@vito
Copy link
Member Author

vito commented Jan 8, 2021

This will no longer be needed with #52 - fetch using registry-image and pass it along using IMAGE_ARG_* instead.

@vito vito closed this as completed in #52 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant