Skip to content

Labels support #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2021
Merged

Labels support #42

merged 2 commits into from
Jan 7, 2021

Conversation

tomjw64
Copy link
Contributor

@tomjw64 tomjw64 commented Oct 28, 2020

Adds support for adding labels to images at build time via LABEL_* or LABELS_FILE params.

Fixes: #41

@tomjw64 tomjw64 force-pushed the labels-support branch 2 times, most recently from 9a7f01b to 37ac3dd Compare October 28, 2020 20:20
vito
vito approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Sorry for the late review, had to meet the Docker Hub rate limiting deadline and then took a long vacation.

It looks like this needs to be rebased, but I'll approve in principle.

@tomjw64
Copy link
Contributor Author

tomjw64 commented Jan 7, 2021

@vito I have rebased it. I hope you had a good vacation. Thanks for reviewing!

@vito vito merged commit 6fc13ad into concourse:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vito vito vito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Image Labels
2 participants
@tomjw64 @vito