Update INTRODUCTION.md with promisified API #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
milindl
commented
Dec 13, 2024
milindl
commented
- What the title says.
- Also update MIGRATION with the particular version of node-rdkafka migration we support.
- I think it's mostly complete. I will link to the API docs whenever I've mentioned them once they are online. This can be in a follow up PR.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
nhaq-confluent
approved these changes
Dec 13, 2024
emasab
requested changes
Dec 14, 2024
MIGRATION.md
Outdated
| The rest of the functionality should work as usual. | ||
|
|
||
| For later releases, the node-rdkafka API diverges from this library. If you encounter any issues migrating, refer to the [INTRODUCTION.md](./INTRODUCTION.md) for a guide to using this library. |
There was a problem hiding this comment.
Suggested change
| For later releases, the node-rdkafka API diverges from this library. If you encounter any issues migrating, refer to the [INTRODUCTION.md](./INTRODUCTION.md) for a guide to using this library. | |
| For releases > v2.17.0, the node-rdkafka API diverges from this library. If you encounter any issues migrating, refer to the [INTRODUCTION.md](./INTRODUCTION.md) for a guide to using this library. |
There was a problem hiding this comment.
Did but with > v2.18.0
There was a problem hiding this comment.
Right, because we did this merge
airlock-confluentinc
bot
force-pushed
the
introduction_document
branch
from
b0b4f68 to
6f2475b
Compare
emasab
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.