[KIP-848]: Structure change for DescribeConsumerGroups #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds two new fields (type and targetAssignment) to the DescribeConsumerGroup response, updates native bindings, JS exports, tests, and examples.
- Extend C++ binding (
common.cc) to includetargetAssignmentand grouptype. - Expose and document
ConsumerGroupTypesin JS library modules. - Update tests and examples to consume the new
typefield.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/promisified/admin/describe_groups.spec.js | Import and assert the new type field |
| src/common.cc | Add targetAssignment and type properties to V8 objects |
| lib/rdkafka.js | Export ConsumerGroupTypes |
| lib/kafkajs/_kafka.js | Include ConsumerGroupTypes in client exports |
| lib/kafkajs/_admin.js | Document and expose ConsumerGroupTypes enum |
| lib/admin.js | Define and freeze ConsumerGroupTypes enum |
| examples/kafkajs/admin/describe-groups.js | Log the new type field in sample output |
Comments suppressed due to low confidence (2)
test/promisified/admin/describe_groups.spec.js:89
- Tests cover the new
typefield but don’t assert the newly addedtargetAssignment. Add assertions to verifygroup.targetAssignmentis returned correctly when present.
type: ConsumerGroupTypes.CLASSIC,
examples/kafkajs/admin/describe-groups.js:75
- The example logs the new
typefield but omitstargetAssignment. Consider adding a line likeconsole.log(\tTarget assignment: ${JSON.stringify(group.targetAssignment)});to illustrate its usage.
console.log(` Type: ${group.type}`);
| * @enum {number} | ||
| * @readonly | ||
| * @memberof KafkaJS | ||
| * @see RdKafka.ConsumerGroupTypes |
There was a problem hiding this comment.
The @see tag references RdKafka.ConsumerGroupTypes but the enum is on RdKafka.AdminClient.ConsumerGroupTypes. Update the annotation to match the actual export path.
Suggested change
| * @see RdKafka.ConsumerGroupTypes | |
| * @see RdKafka.AdminClient.ConsumerGroupTypes |
Copilot uses AI. Check for mistakes.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add two new field type and target assignment for DescribeConsumerGroup Response.