Skip to content

Oauth OIDC CCloud producer example #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

pranavrth
Copy link
Member

Continuation of #1593 as the owner of the PR left the org.

@pranavrth pranavrth requested a review from a team as a code owner June 24, 2024 08:41
Copy link

cla-assistant bot commented Jun 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jun 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pranavrth
❌ sarwarbhuiyan
You have signed the CLA already but the status is still pending? Let us recheck it.

@pranavrth pranavrth force-pushed the dev_oauth-oidc-ccloud-producer-example branch 3 times, most recently from 6299ce8 to 960f4b0 Compare June 25, 2024 08:52
@pranavrth pranavrth force-pushed the dev_oauth-oidc-ccloud-producer-example branch from ab067b5 to 7b715b2 Compare July 11, 2024 09:14
@pranavrth pranavrth requested a review from a team as a code owner July 11, 2024 09:14
Comment on lines +19 to +21
# This uses OAuth client credentials grant:
# https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/
# where client_id and client_secret are passed as HTTP Authorization header
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This uses OAuth client credentials grant:
# https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/
# where client_id and client_secret are passed as HTTP Authorization header
# This uses OAuth client credentials grant:
# https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/
# where client_id and client_secret are passed as HTTP Authorization header
# with the OIDC method and doesn't need to set a `oauth_cb` to obtain the token,
# but, given it's using cURL for http requests, when using bundled librdkafka on non RHEL based distros,
# currently it needs to provide CA bundle at a specific path, that is `/etc/pki/tls/certs/ca-bundle.crt`.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_oauth-oidc-ccloud-producer-example branch from f099862 to 95dbc87 Compare October 15, 2024 06:12
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@pranavrth pranavrth merged commit e17f6e2 into master Oct 15, 2024
3 checks passed
@pranavrth pranavrth deleted the dev_oauth-oidc-ccloud-producer-example branch October 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants