[KIP-848] Test changes required for KIP-848 Preview #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
dev_kip848-preview-push
branch
from
6d63e77 to
1e8d017
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…' protocol 2) Fixed test related to assign and unassign in incremental assignor case for 'consumer' protocol
…ses session.timeout.ms
airlock-confluentinc
bot
force-pushed
the
dev_kip848-preview-push
branch
from
d1f69e4 to
cd08695
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
emasab
reviewed
Apr 17, 2025
| e = f.exception(timeout=1) | ||
| assert isinstance(e, KafkaException) | ||
| assert e.args[0].code() == KafkaError._TIMED_OUT | ||
| # with pytest.raises(KafkaException): |
There was a problem hiding this comment.
This is raising Fatal error intermittently in Python build for MacOS. I am not able to reproduce this. Not able to reproduce the issue even with M2 mac.
There was a problem hiding this comment.
I will add a PR to enable them again.
There was a problem hiding this comment.
ok, please add a comment for now
This comment has been minimized.
This comment has been minimized.
emasab
requested changes
Apr 17, 2025
| "group.protocol.type"] | ||
| for prop in forbidden_conf_properties: | ||
| if prop in conf: | ||
| del conf[prop] |
There was a problem hiding this comment.
Could you add a message here as in other clients
Analysis Details4 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
emasab
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.