Fixed Exception caused by Empty Lines in config file. #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoadConfig method caused an exception due to the fact that the Where filter did not filter out empty lines in the Config file, causing an exception when running the C# demo with the provided config file in C# Setup Guide.
|
@bbejeck do you happen to have the right environment set up to validate this PR? |
Yes - I have .NET versions 3, 5, and 6 installed - I can test against all 3 |
bbejeck
approved these changes
May 17, 2022
|
Tested against .NET 6 and 5 - .NET 3 is pretty old and not compatible with |
|
@bbejeck thanks so much for validating and @JBeamer92 thanks again for the PR! Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What behavior does this PR change, and why?
The config file provided in the C# setup contains empty lines with a Length of 0. This was causing Exceptions when trying to read the config file in the LoadConfig method because the empty lines were not being filtered out by the Where clause. By filtering out empty lines with a length of 0, the LoadConfig method completes without exceptions and the application completes as expected.
Author Validation
Describe the validation already done, or needs to be done, by the PR submitter.
Verified using .NET 6.0. Needs to be tested against earlier versions of .NET to prove backwards compatibility.
[ ] clients/cloud
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.
Needs to be tested against earlier versions of .NET to prove backwards compatibility.
[ ] clients/cloud