Skip to content

DEVX-2463-cont: replace -f removal of files #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Conversation

awalther28
Copy link
Contributor

@awalther28 awalther28 commented Jan 22, 2021

Description

What behavior does this PR change, and why?

In #920 @rspurgeon suggested

IMO we do not need -f here. I tested this command without, and considering the user previously created the file in a folder that they have proper permissions on, the -f isn't required. So introducing the force option seems like an unecessary risk, in case something important (oddly) happen to get into the KSQLDB_SERVER_DELTA variable.

If we want to silence error messages if the file doesn't exist, i suggeste we use rm $KSQLDB_SERVER_DELTA 2>/dev/null

To be cautious we should refrain from force removing files in our demos when we don't have to. This PR changes for rm -f to rm $KSQLDB_SERVER_DELTA 2>/dev/null. I validated this by running ccloud-stack-create (generating configs with both bash and zsh) and running the microservices demo.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

  • ccloud

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

  • ccloud
  • other cloud demos that use ccloud-stack-create

@awalther28 awalther28 requested a review from a team January 22, 2021 22:10
@awalther28 awalther28 marked this pull request as ready for review January 22, 2021 22:10
Copy link
Contributor

@rspurgeon rspurgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants