Skip to content

Fixing SunsetAirFlightData reference and test #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DavidGonzalezPineiro
Copy link

Fixes #21

Description

  • Corrected the KafkaSource builder for sunsetSource in FlightImporterJob.java to use the proper generic type SunsetAirFlightData instead of mistakenly using SkyOneAirlinesFlightData.

  • Enhanced the SunsetAirFlightDataTest by updating the JSON test input and adding a more thorough deserialization test that:

    • Uses the correct JSON property names matching the model.
    • Parses ZonedDateTime fields with explicit UTC zone handling.
    • Verifies full object equality after deserialization, ensuring unknown JSON fields are safely ignored.

Checklist

  • Unit tests created/updated for any new code (where applicable).
  • Run all tests with ./build.sh validate.
  • Update the CHANGELOG.md.
  • Update the README.md if necessary.

@DavidGonzalezPineiro DavidGonzalezPineiro requested a review from a team as a code owner May 15, 2025 12:22
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented May 15, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ DavidGonzalezPineiro
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Contributor

@WadeWaldron WadeWaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the changes.

@WadeWaldron
Copy link
Contributor

@DavidGonzalezPineiro If you can sign the Contributor License Agreement (see above), we can get this merged.

@DavidGonzalezPineiro DavidGonzalezPineiro force-pushed the fix/sunsetairflightdata-kafka-source-reference branch from c416c95 to 16a862c Compare May 16, 2025 07:36
@DavidGonzalezPineiro DavidGonzalezPineiro force-pushed the fix/sunsetairflightdata-kafka-source-reference branch from 16a862c to f993d26 Compare May 16, 2025 07:42
@DavidGonzalezPineiro
Copy link
Author

Done. Thank you! I'm glad you liked it. And many thanks to you as well for all your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix KafkaSource generic type and improve SunsetAirFlightData deserialization test
2 participants