Skip to content

Commit f36159a

Browse files
authored
Merge pull request #190 from jdef/consolidate_probe_rpcs
spec: consolidate xxxProbe calls into Identity.Probe
2 parents 2571bd3 + 948e2ec commit f36159a

File tree

3 files changed

+309
-392
lines changed

3 files changed

+309
-392
lines changed

csi.proto

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ service Identity {
1212

1313
rpc GetPluginCapabilities(GetPluginCapabilitiesRequest)
1414
returns (GetPluginCapabilitiesResponse) {}
15+
16+
rpc Probe (ProbeRequest)
17+
returns (ProbeResponse) {}
1518
}
1619

1720
service Controller {
@@ -36,9 +39,6 @@ service Controller {
3639
rpc GetCapacity (GetCapacityRequest)
3740
returns (GetCapacityResponse) {}
3841

39-
rpc ControllerProbe (ControllerProbeRequest)
40-
returns (ControllerProbeResponse) {}
41-
4242
rpc ControllerGetCapabilities (ControllerGetCapabilitiesRequest)
4343
returns (ControllerGetCapabilitiesResponse) {}
4444
}
@@ -59,9 +59,6 @@ service Node {
5959
rpc NodeGetId (NodeGetIdRequest)
6060
returns (NodeGetIdResponse) {}
6161

62-
rpc NodeProbe (NodeProbeRequest)
63-
returns (NodeProbeResponse) {}
64-
6562
rpc NodeGetCapabilities (NodeGetCapabilitiesRequest)
6663
returns (NodeGetCapabilitiesResponse) {}
6764
}
@@ -148,6 +145,16 @@ message PluginCapability {
148145
}
149146
////////
150147
////////
148+
message ProbeRequest {
149+
// The API version assumed by the CO. This is a REQUIRED field.
150+
Version version = 1;
151+
}
152+
153+
message ProbeResponse {
154+
// Intentionally empty.
155+
}
156+
////////
157+
////////
151158
message CreateVolumeRequest {
152159
// The API version assumed by the CO. This field is REQUIRED.
153160
Version version = 1;
@@ -511,14 +518,6 @@ message GetCapacityResponse {
511518
}
512519
////////
513520
////////
514-
message ControllerProbeRequest {
515-
// The API version assumed by the CO. This is a REQUIRED field.
516-
Version version = 1;
517-
}
518-
519-
message ControllerProbeResponse {}
520-
////////
521-
////////
522521
message ControllerGetCapabilitiesRequest {
523522
// The API version assumed by the CO. This is a REQUIRED field.
524523
Version version = 1;
@@ -730,14 +729,6 @@ message NodeGetIdResponse {
730729
}
731730
////////
732731
////////
733-
message NodeProbeRequest {
734-
// The API version assumed by the CO. This is a REQUIRED field.
735-
Version version = 1;
736-
}
737-
738-
message NodeProbeResponse {}
739-
////////
740-
////////
741732
message NodeGetCapabilitiesRequest {
742733
// The API version assumed by the CO. This is a REQUIRED field.
743734
Version version = 1;

0 commit comments

Comments
 (0)