Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is VERSION file necessary? #324

Open
saad-ali opened this issue Nov 12, 2018 · 3 comments
Open

Is VERSION file necessary? #324

saad-ali opened this issue Nov 12, 2018 · 3 comments
Labels
post-v1 priority/p2

Comments

@saad-ali
Copy link
Member

Follow up from #321 (comment)

Do we still need the VERSION file? If not, lets remove it.
@saad-ali saad-ali added this to the v1.0 milestone Nov 12, 2018
@saad-ali saad-ali mentioned this issue Nov 12, 2018
Merged
@saad-ali
Copy link
Member Author

Not a blocker for 1.0

@saad-ali saad-ali removed this from the v1.0 milestone Nov 12, 2018
@julian-hj
Copy link
Contributor

so....if we remove the version file, where do we maintain a record of the current version? I had the notion that folks might consume VERSION in their build scripting, given that protobuf doesn't define it.

If we were to come up with some solution for #170 then I'd agree that this file is unnecessary, but until then, I think if we get rid of it, we'd be forcing everyone to manually define the CSI version they are using, which seems a bid shady to me.

@jieyu
Copy link
Member

jieyu commented Nov 12, 2018

I think version can be derived from the tag (e.g., v0.3.0, or v1.0.0, etc.) for releases?

@saad-ali saad-ali mentioned this issue Mar 8, 2019
Merged
@saad-ali saad-ali mentioned this issue Oct 23, 2019
Merged
saad-ali added a commit that referenced this issue Jun 3, 2020
@saad-ali
Bump master version to 1.4 for next release
84f1725 
Now that CSI v1.3.0 has been cut: https://github.com/container-storage-interface/spec/releases/tag/v1.3.0
Bumping version for 1.4 release.
We have to do this until #324 is resolved.
@saad-ali saad-ali mentioned this issue Jun 3, 2020
Merged
@saad-ali saad-ali mentioned this issue Mar 8, 2021
Merged
@saad-ali saad-ali mentioned this issue Jun 12, 2021
Merged
@saad-ali saad-ali mentioned this issue Apr 5, 2022
Merged
@saad-ali saad-ali mentioned this issue Nov 3, 2022
Merged
@saad-ali saad-ali mentioned this issue Mar 9, 2023
Merged
@saad-ali saad-ali mentioned this issue Oct 18, 2023
Merged
@saad-ali saad-ali mentioned this issue Jul 2, 2024
Merged
@saad-ali saad-ali mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-v1 priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jieyu @julian-hj @saad-ali