Skip to content

spec: consolidate xxxProbe calls into Identity.Probe #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2018
Merged

spec: consolidate xxxProbe calls into Identity.Probe #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91c1897
spec: consolidate xxxProbe calls into Identity.Probe
Feb 5, 2018
948e871
spec: clarify 1) intent of Probe; 2) configuration of operating mode
Feb 16, 2018
948e2ec
address review feedback
Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ service Identity {

rpc GetPluginCapabilities(GetPluginCapabilitiesRequest)
returns (GetPluginCapabilitiesResponse) {}

rpc Probe (ProbeRequest)
returns (ProbeResponse) {}
}

service Controller {
Expand All @@ -36,9 +39,6 @@ service Controller {
rpc GetCapacity (GetCapacityRequest)
returns (GetCapacityResponse) {}

rpc ControllerProbe (ControllerProbeRequest)
returns (ControllerProbeResponse) {}

rpc ControllerGetCapabilities (ControllerGetCapabilitiesRequest)
returns (ControllerGetCapabilitiesResponse) {}
}
Expand All @@ -59,9 +59,6 @@ service Node {
rpc NodeGetId (NodeGetIdRequest)
returns (NodeGetIdResponse) {}

rpc NodeProbe (NodeProbeRequest)
returns (NodeProbeResponse) {}

rpc NodeGetCapabilities (NodeGetCapabilitiesRequest)
returns (NodeGetCapabilitiesResponse) {}
}
Expand Down Expand Up @@ -148,6 +145,16 @@ message PluginCapability {
}
////////
////////
message ProbeRequest {
// The API version assumed by the CO. This is a REQUIRED field.
Version version = 1;
}

message ProbeResponse {
// Intentionally empty.
}
////////
////////
message CreateVolumeRequest {
// The API version assumed by the CO. This field is REQUIRED.
Version version = 1;
Expand Down Expand Up @@ -511,14 +518,6 @@ message GetCapacityResponse {
}
////////
////////
message ControllerProbeRequest {
// The API version assumed by the CO. This is a REQUIRED field.
Version version = 1;
}

message ControllerProbeResponse {}
////////
////////
message ControllerGetCapabilitiesRequest {
// The API version assumed by the CO. This is a REQUIRED field.
Version version = 1;
Expand Down Expand Up @@ -730,14 +729,6 @@ message NodeGetIdResponse {
}
////////
////////
message NodeProbeRequest {
// The API version assumed by the CO. This is a REQUIRED field.
Version version = 1;
}

message NodeProbeResponse {}
////////
////////
message NodeGetCapabilitiesRequest {
// The API version assumed by the CO. This is a REQUIRED field.
Version version = 1;
Expand Down
Loading