-
Notifications
You must be signed in to change notification settings - Fork 379
Add new GroupControllerService and VolumeGroupSnapshot CSI RPCs #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jdef
merged 13 commits into
container-storage-interface:master
from
xing-yang:volume_group
Feb 21, 2023
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f456630
Add VolumeGroupSnapshot CSI RPCs
xing-yang b3e48c6
Add FAILED_PRECONDITION
xing-yang 2653144
Address review comments
xing-yang 11d9ad3
Add ready_to_use back to VolumeGroupSnapshot
xing-yang 24b2d18
Update comments
xing-yang f595ae3
Address review comments
xing-yang 4b8f143
Clarified requirements for consistency
xing-yang 7445a3a
Update comments about group snapshot id
xing-yang 5286513
Address review comments.
xing-yang 1bc24d7
Address comments
xing-yang 8959d25
Added INVALID_ARGUMENT for snapshot id mismatch
xing-yang 4ced11b
Adds snapshot_ids to GetVolumeGroupSnapshotRequest
xing-yang 536316f
Use INVALID_ARGUMENT error code
xing-yang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.