[CI] Update wincni #4055
Merged
[CI] Update wincni #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
AkihiroSuda
reviewed
Mar 29, 2025
| # nat already exists on the Windows VM, the subnet and gateway | ||
| # we specify should match that. | ||
| : "${GATEWAY:=$(powershell -c "(Get-NetIPAddress -InterfaceAlias 'vEthernet (nat)' -AddressFamily IPv4).IPAddress")}" | ||
| : "${PREFIX_LEN:=$(powershell -c "(Get-NetIPAddress -InterfaceAlias 'vEthernet (nat)' -AddressFamily IPv4).PrefixLength")}" |
There was a problem hiding this comment.
Any reason not to use PowerShell for the entire script?
There was a problem hiding this comment.
Just lazyness. I do not know much about PowerShell and have no windows laptop...
There was a problem hiding this comment.
Maybe somebody more windows inclined could look into this in an upcoming PR and powershell it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinCNI is currently installed by a third-party script that retrieves a very old version.
This adopts the script - which allows us to control the version we want and saves us having to clone out containerd-v1.7.