Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: env_file in compose work with profile #4073

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Apr 3, 2025

Currently, the code does not automatically parse env_file when using profiles. This issue can be fixed by replacing project.WithProfiles with composecli.WithProfiles.

fix: #4069

@yankay yankay changed the title Fix env_file in compose work with profile Fix: env_file in compose work with profile Apr 3, 2025
@yankay yankay force-pushed the fix-profile-in-compose branch from b5e64df to 8b06f2a Compare April 3, 2025 12:49
@yankay yankay changed the title Fix: env_file in compose work with profile [WIP]Fix: env_file in compose work with profile Apr 3, 2025
@yankay yankay changed the title [WIP]Fix: env_file in compose work with profile Fix: env_file in compose work with profile Apr 3, 2025
@manugupt1
Copy link
Contributor

Thanks!

@manugupt1 manugupt1 added this to the v2.0.5 milestone Apr 4, 2025
@yankay
Copy link
Contributor Author

yankay commented Apr 7, 2025

HI @fahedouch @AkihiroSuda
Would you please help to review this PR :-)

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 6092e0b into containerd:main Apr 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env_file doesn't work with profiles
3 participants