[STACKED] [Tigron]: expect.JSON comparator and updated volume test #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
- use internal/com instead of icmd - move pty from test/internal to internal - update go mod, sum, and depguard Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
- Background() signature change - command creation change Signed-off-by: apostasie <[email protected]>
- Background - Feed, WithFeeder, WithPseudoTTY - use exit code consts where appropriate - some --quiet Signed-off-by: apostasie <[email protected]>
This commit relaxes line length from 100 to 120, and disables a bunch of linters we do not want. Signed-off-by: apostasie <[email protected]>
Mimicry is a lightweight, zero dependency mock mechanism created to ease testing of Tigron. Since Tigron heavily relies on *testing.T, it is currently hard to test. Moving away to a tig.T interface instead of *testing.T will unlock the ability to mock. Mimicry does provide: - recording of all function calls, with arguments and complete stack trace (see Report()) - optional custom handling of function calls (see Register()) - QOL: fancyfied OCS8 links allow opening files from traces in terminal UX is largely in flux right now and experimental, but the objective is to: - do not require code generation - do not abuse reflection - keep the amount of boilerplate to the absolute minimum for the mock consumer - ... and as small as possible for the mock creator - keep zero dependencies This commit also introduce the tig.T interface to be used everywhere inside Tigron in the future, along with a complete mock for it. Mimicry is not meant to be used directly for now, though, if there is interest, a future version might graduate out of `internal`. Signed-off-by: apostasie <[email protected]>
This brings a set of enhancements to assertive: - function name simplifications - generics-ifying of some functions that can be used on comparables - additional methods (Match, DoesNotMatch) - debugging output is made clear, along with OCS8 link and excerpt of the test file - all methods can now elect to Fail later instead of FailNow - Check method is removed (^ because of above) - all methods can now elect to silence output on success Other Tigron files are updated to adopt these changes: - method names update - comparators move away from Check and now fully leverages assertive This also adds a large number of tests for assertive, leveraging mimicry. Signed-off-by: apostasie <[email protected]>
Prior, only BlackList-ing of environment variables was supported, and solely for exact variable names match, or "*" for all. This changeset introduces: - WhiteList-ing - prefix matching for env var names (eg: "THING_*" can now be used to white/black list any env variable which name starts with THING_) Signed-off-by: apostasie <[email protected]>
This is mostly a cosmetic changeset: - refined golangcilint, explicitly calling which linters we really care about, along with settings for revive - comments on reasons for some of //nolint - comments line breaks - additional FIXME information - assert type check fixes - const-ification - overall making linter happy(-ier) - some tests enhanced with added info And: - adding a WhiteList test for internal/com Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-3-json-comparator
branch
5 times, most recently
from
72c91fe to
dfe8488
Compare
This changeset adds expect.JSON[T any], which will allow easier testing of json output and hopefully remove a lot of boilerplate unmarshalling / assert in tests. It also adds an extensive doc.md document about comparators (plan is trim down the main documentation to a small set of simple examples, then link to these "advanced" docs for further reading), which will allow for easier documentation maintenance and more approachable reading. Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-3-json-comparator
branch
from
dfe8488 to
9f2f884
Compare
In some cases, exec is just really slow. Adjusting tests so that we start counting after the command actually started. Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-3-json-comparator
branch
from
9f2f884 to
b9eecf1
Compare
apostasie
changed the title
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<!> Blocked by <!>:
This is a new series of Tigron PRs.
Now that the big change with the new command implementation is in, upcoming work on Tigron will focus on:
Ideally, none of these PRs will require ANY change in nerdctl, and are either changes to the way we test Tigron itself, or refactoring that does not change signatures and API.
Efforts are being made to break these PRs down into small, digestible changes to ease and fasten review, which explains the chain of PRs.
LMK at any point if a given PR needs to be further broken down.
This third PR is very small as well:
Commit 1 adds support for
expect.JSON[T].The point is to remove repeated json unmarshalling boilerplate from tests.
Parsing JSON of course is not complex, but it adds unnecessary noise to tests.
Second commit does change a couple of tests in nerdctl purely to demonstrate usage.
Third commit is unrelated, but does fix a condition that triggered a failure on this specific PR, and is a minor test adjustment.